[Octave-bug-tracker] [bug #52800] The icon for dock widgets for *figure* windows needs improvement

[Dan Sebald]

Follow-up Comment #3, bug #52800 (project octave):

It's odd, but the graphic and letter icons don't seem to be working at the
moment.  All I'm seeing is the main icon, regardless of what setting I
choose.

Anyway, I understand the reason for having some default.  However, my point
was that the construct isn't correct.  Perhaps writing out the alternative
approach that I think is correct will help.

The original is:


(1)  ui->general_icon_octave->setChecked (true);  // the default (if invalid
set)
(2)  ui->general_icon_octave->setChecked (widget_icon_set == "NONE");
(3)  ui->general_icon_graphic->setChecked (widget_icon_set == "GRAPHIC");
(4)  ui->general_icon_letter->setChecked (widget_icon_set == "LETTER");


Imagine there is some bogus setting in the settings file, i.e., not NONE, not
GRAPHIC and not LETTER.  In that case immediately after line 1, the state of
the button gets set back to false in line 2.  Instead, if it were done as


  if (widget_icon_set == "GRAPHIC")
    ui->general_icon_graphic->setChecked (true);
  else if (widget_icon_set == "LETTER")
    ui->general_icon_letter->setChecked (true);
  else
    ui->general_icon_octave->setChecked (true);  // the default (if invalid
set)


then the general_icon_octave is left in a "true" state, rather than a "false"
state.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52800>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/