[Octave-bug-tracker] [bug #53978] Octave 4.4 fails to build against Qt 5.11

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?53978>

                 Summary: Octave 4.4 fails to build against Qt 5.11
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Thu 24 May 2018 07:29:35 PM PDT
                Category: Configuration and Build System
                Severity: 4 - Important
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: Confirmed
             Assigned to: mtmiller
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.4.0
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Octave fails to compile against Qt 5.11 with a few instances of the following
error


../libgui/src/settings-dialog.cc: In constructor
‘settings_dialog::settings_dialog(QWidget*, const QString&)’:
../libgui/src/settings-dialog.cc:302:57: error: invalid use of incomplete type
‘class QButtonGroup’
   QButtonGroup *icon_size_group = new QButtonGroup (this);
                                                         ^
In file included from
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qtoolbutton.h:45:0,
                 from
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/QToolButton:1,
                 from ../libgui/src/octave-dock-widget.h:30,
                 from ../libgui/src/variable-editor.h:33,
                 from ../libgui/src/settings-dialog.cc:33:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note:
forward declaration of ‘class QButtonGroup’
 class QButtonGroup;
       ^~~~~~~~~~~~


all in settings-dialog.cc.

This looks pretty simple and reasonable to fix on stable with an extra
include, will test and push the fix as soon as I have a bug number.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53978>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/