[Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal

[John W. Eaton]

Follow-up Comment #14, bug #48505 (project octave):

Rik: Thanks, that patch will work, but I thought we should use the prototype
for xerbla that is in lo-blas-proto.h instead of repeating it in xerbla.c.  So
I included lo-blas-proto.h there and immediately found that it will only work
with C++ because of our use of references instead of pointers.  I don't want
to give that up, or complicate things by using references for C++ code and
pointers for C code, so I ended up converting xerbla to C++.  Then the
prototypes aren't needed.  Here's my change (accidentally pushed as two
changesets when I should have merged them before pushing):

http://hg.savannah.gnu.org/hgweb/octave/rev/9ea68b9e277b
http://hg.savannah.gnu.org/hgweb/octave/rev/a8325f2361c7

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48505>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/