[Octave-bug-tracker] [bug #54636] path is not be reinitialized if a class directory is modified

[Mike Miller]

Follow-up Comment #5, bug #54636 (project octave):

Yes, probably a file size issue. The "upload size limit" mentioned is not
reliable.

Thanks for working on improving this. The new patch looks good, better that it
doesn't need to add a new method to the class.

The indentation on the nested 'if' statements in 'subdirs_modified' is not
quite right. And you might as well combine all of those nested 'if's into one
complex condition, since there is no 'else'. That might look something like


            if (fs && fs.is_dir () && (fname[0] == '@' || fname[0] == '+'
                                       || fname == "private")
                && (fs.mtime () + fs.time_resolution () > last_checked)
              {
                ret = true;
                break;
              }


The first summary line of the commit message should mention this and any other
bug reports fixed by this change with a "(bug #1, #2, #3)" tag at the end of
the line.

Thanks for doing a full test suite run as well as showing the test cases that
this bug resolves.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54636>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/