[Octave-bug-tracker] [bug #54614] [octave forge] (image) wrong results of entropyfilt

[Carnë Draug]

Update of bug #54614 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

> The function spatial_filtering should also have a check that S and DOMAIN
have the exact same dimensions.

Now done with http://hg.code.sf.net/p/octave/image/rev/aecc2d33b0a6

I have pushed the rest of the patch with
http://hg.code.sf.net/p/octave/image/rev/ae48f7ddee82 which fixes the issues
and so I'm closing it.

Hartmut wrote on comment #7:
> Do you have a clever idea, how to:
> * use _spatial_filtering_ (keeping its 4t input argument alive)
> * not use more memory than necessary
> * and still be able to tell _spatial_filtering_ in most use cases to NOT add
this forth argument to the result?
> Maybe we could find a trick inside _spatial_filtering_ to treat an EMPTY
forth argument as a matrix of zeros (of size(I)) , but without actually
requirement memory for all those zeros? Do you have a clever idea how to
implement this in _spatial_filtering_?

The memory usage is not a problem because the 4th input argument is an array
the same size as the domain which is typically much smaller than the actual
image. The issue is the extra computations since we will be adding zero many
times. I think this could be avoided with templates which should also make the
code simpler to follow. Not sure it's worth the time, but feel free to give it
a go.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54614>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/