[Octave-bug-tracker] [bug #54882] fail to build with Qt 4.8: class QPointer<> has no member named 'clear'

[Torsten]

Follow-up Comment #4, bug #54882 (project octave):

You are right, the current code (clear) does not destroy the octave_cmd
object. Obviously, I have misinterpreted the documentation. The following
simple patch fixes the issue and is backward compatible


diff -r e9c24b5e8673 libgui/src/octave-cmd.cc
--- a/libgui/src/octave-cmd.cc  Thu Oct 11 18:46:05 2018 +0200
+++ b/libgui/src/octave-cmd.cc  Wed Oct 24 13:37:40 2018 +0200
@@ -178,7 +178,7 @@ namespace octave
             cmd_gp->execute (interp);
           }
 
-        cmd_gp.clear ();    // remove the original cmd pointer
+        delete cmd_gp;    // destroy the referred octave_cmd object
       }
 
     if (repost)  // queue not empty, so repost event for further processing


I am going to prepare a changeset.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54882>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/