[Octave-bug-tracker] [bug #54922] demo surfl 1 fails

[Markus Mützel]

Update of bug #54922 (project octave):

                  Status:               Confirmed => Patch Submitted        
        Operating System:               GNU/Linux => Any                    

    _______________________________________________________

Follow-up Comment #2:

Thanks Rik for pointing this to me.

With that change, we only calculate face or vertex normals "if they are
needed". That means, "facenormals" are calculated only for flat lighting and
only if a light object is present in the same axes. Similarly, "vertexnormals"
are calculated only for gouraud lighting and if a light object is present in
the same axes.
This was done to avoid calculating these properties when they aren't necessary
(could be costly if there were many faces and vertices). This is also what
Matlab seems to do.

The attached patch sets the "facelighting" property of the surface that is
created in surfl and temporarily adds a light object to its parent axes.

It also adds an "only" to the respective sentence in the "NEWS" file. Please
let me know if we should be any more wordy there. This might be a
compatibility consideration for existing user code as well.

Alternatively, we could always calculate the face and vertex normals (not only
if certain pre-conditions are met).

(file #45340)
    _______________________________________________________

Additional Item Attachment:

File name: bug54922_surfl_vertexnormals.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54922>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/