[Octave-bug-tracker] [bug #45088] [octave forge] (image) rangefilt requires domain and image to have equal number of dimensions

[Hartmut]

Follow-up Comment #24, bug #45088 (project octave):

How do we proceed with this?

At the moment (i.e. after pushing the improvements on spatial_filtering.cc
with http://hg.code.sf.net/p/octave/image/rev/aecc2d33b0a6 , see bug #54614)
the original problem (comment #0) still persists: rangefilt (and several other
filtering functions) require domain and image to have the same number of
dimensions. This is still needed by (and tested by) the underlying
spatial_filtering.cc.

There are several options to proceed with this:
* (A) We change the m-code in (several) filtering functions, to add padding in
each individual filtering function. This is what Avinoam's patches in this bug
report started to do, and what Carne does not like (see his comment #19), but
what seemd to work fine and in a Matlab compatible way (see comment #21).
* (B) We do this padding inside of spatial_filtering.cc, this means in c code.
This might be not so nice work (at least I am not eager to code this.) This is
what Carne proposed (comment #19)
* (C) We introduce a new m-code function, that does the padding. (Or is there
already an existing function that can be used for this?) And we then call this
function from inside all the relevant filtering functions.
* (D) Do don't do anything about this. We only state this behavior correctly
in the help text.

My personal preference would be (A). (My second favorite choice would be
variant C, but this new m-function will probably only have 5 lines of code and
therefore in my opinion not be worth the effort of maintaining a seperate
private function.) What do othe people think about this?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?45088>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/