[Octave-bug-tracker] [bug #54995] Removal of called_from_builtin

[Guillaume]

URL:
  <https://savannah.gnu.org/bugs/?54995>

                 Summary: Removal of called_from_builtin 
                 Project: GNU Octave
            Submitted by: gyom
            Submitted on: Fri 09 Nov 2018 04:56:17 PM UTC
                Category: Interpreter
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: None
             Assigned to: None
         Originator Name: Guillaume
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

The called_from_builtin function was recently removed:

https://hg.savannah.gnu.org/hgweb/octave/rev/920a4ad8043b

It has the consequence of reintroducing the bug described here:

http://lists.gnu.org/archive/html/help-octave/2009-04/msg00307.html

and initially fixed there (where called_from_builtin was added):

http://hg.savannah.gnu.org/hgweb/octave/rev/b2b8ed43b922

For simplicity, I copy here a small example that illustrates the bug:


# Save as @myclass/myclass.m
function obj = myclass ()

  obj = struct ("a", rand(1));
  obj = class(obj, "myclass");

endfunction



# Save as @myclass/subsref.m
function val = subsref (obj, S)

  idx.type = S.type;
  idx.subs = {S.subs};

  val = builtin ("subsref", obj, idx);

endfunction



octave> obj = myclass ();
octave> obj.a
error: max_recursion_depth exceeded
error: called from
    subsref at line 6 column 7


A positive consequence is that it fixes bug #32296, e.g. Mike's example from
comment #7 now works.





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54995>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/