[Octave-bug-tracker] [bug #50874] [octave forge] (image) bwdist call causes application crash

[Hartmut]

Follow-up Comment #9, bug #50874 (project octave):

I tried to review this patch (file #45484) as good as I could. Here are my
comments:
* I have done my testing only on a linux machine. I did not see any crashes,
neither on the code from commment #0 nor comment #5. But I have done NO
TESTING on a WINDOWS machine, so I cannot tell of the segfault is gone now.
* I am not so fluent in C. So I have NOT CHECKED the added functionality of
this patch on a principle basis.
* The tests all pass for me. The old tests as well as the newly added tests.
* I get compatible results now for the examples in comment #6.
* There is not yet a commit message, nor a text for the NEWS file in the
patch, yet.

So, as far as I can tell now this patch seems to be fine.

It would be nice to get
* (A) someone more fluent in C to have a look at the newly added code pieces
on a principal basis. @Carne ?
* (B) someone to test this on a Windows machine. I will try to do this once I
get access to a Windows machine.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?50874>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/