[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #55059] [octave forge] (image) Failing unit te
From: |
Hartmut |
Subject: |
[Octave-bug-tracker] [bug #55059] [octave forge] (image) Failing unit test for grayslice |
Date: |
Fri, 7 Dec 2018 06:06:44 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0 |
Follow-up Comment #14, bug #55059 (project octave):
Currently all the results of the Octave grayslice function (in the repo) are
Matlab compatible when running my test code from comment #13 (using a vector v
for slicing).
My test code from comment #9 is giving different results on Matlab as on
Octave currently. But I just realised that this difference is only for FLOAT
IMAGES with VALUES BIGGER THAN 1. Because I unintentionally forgot to imcast
the integer input images in these test codes. Currently ALL input images are
of class double (because counter-intuitivly the output value of the intmin
function is of class double).
Conclusion:
* The non-compatible results from my current test code in comment #9 (wich
were Carne's concern in comment #12) are not such a big thing. Because input
images of class double but with most values bigger than 1 are no common use
case anyway. The result is kind of undefined in my opinion.
* I will try to supply Matlab results for more meaningful test codes next
week.
Note: I haven't understood yet, why the one xtest in the current repo version
is failing.
Question: Are all the tests in the function code currently Matlab compatible?
(aka: Do I make things worse if I change the fucntion code and some of the
tests start to fail?)
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55059>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/