[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48774] Functions for moving statistics
From: |
Juan Pablo Carbajal |
Subject: |
[Octave-bug-tracker] [bug #48774] Functions for moving statistics |
Date: |
Fri, 21 Dec 2018 03:33:01 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0 |
Follow-up Comment #30, bug #48774 (project octave):
Hi Rik,
Thank you for taking the time to answer all my comments.
1. I will merge your changes and go back to the dispatch structure, since I
think it adds to maintainability. I do not think that the new information
hinders its applicability at all. Aslo the working done in "discard" should be
put in a "discard_bc" not to violate the concerns of the functions. Do you
foresee a strike in performance by moving the code in the switch to a
subfunction?
2. Regarding copyright. Since you were exposed and clearly saw my code on the
wrappers I do not think that this is a case for Clean-room design. I will be
very happy if my name appears in those wrappers so future users can link to me
as well.
I also noticed that you removed author and creation date but many functions in
octave core have those fields. Is this a personal criteria or is something the
community wants to remove?
3. Isn't it better to have __parser_movargs__ as a private function in the
scripts/statistics folder? So far only wrappers there are using it, right?
Regards,
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?48774>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, (continued)
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Juan Pablo Carbajal, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Rik, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Rik, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Rik, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Rik, 2018/12/19
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics,
Juan Pablo Carbajal <=
- [Octave-bug-tracker] [bug #48774] Functions for moving statistics, Rik, 2018/12/21