octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #65421] patch fails to render if cdata is spec


From: Nicholas Jankowski
Subject: [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form
Date: Tue, 12 Mar 2024 15:08:51 -0400 (EDT)

Update of bug #65421 (group octave):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                 
                 Summary: patch fails to render if cdata is specified before
geometry => patch fails to render if cdata is specified before geometry in
property/value calling form

    _______________________________________________________

Follow-up Comment #28:

@liang:  there is no difference in this case for a command being process
like:


patch ('xdata', x, 'ydata', y, 'cdata', c)

or 


patch ('xdata', x, ...
       'ydata', y, ...
       'cdata', c);


this specific issue only deals with color data appearing before geometry data
when using the 'property' 'value' calling form.

my goal was for the fix to make minimal changes, so it only slides the
geometry items (xdata, ydata, zdata, faces, vertices) to the front without
changing the relative order of those inputs or the ones that follow.  That
satisfied this specific compatibility issue. 

but yes, that's fine keeping this on default. Since this change relaxed the
(unanticipated) ordering requirement I think the docs on default don't need
any changing.  It may warrant adding a line to the help on stable.  i added a
few property related notes to the end of the patch docstring that I believe
adequately describes the current state of what will go out soon in octave 9
and pushed as https://hg.savannah.gnu.org/hgweb/octave/rev/773c6bd19630. 

closing this report as fixed.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65421>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]