[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
make check fails for CVS
From: |
Todd Neal |
Subject: |
make check fails for CVS |
Date: |
Mon, 7 Feb 2005 00:07:37 -0500 |
User-agent: |
Mutt/1.4.1i |
"make check" fails for the current CVS version. The problem is with
dec2base.m:
Running ./octave.test/string/string.exp ...
FAIL: octave.test/string/dec2bin-3.m
FAIL: octave.test/string/dec2hex-3.m
In dec2base.m this check ignores the len argument:
92 ## Check if the first element is the zero symbol
93 if (all (retval(:,1) == symbols(1)))
94 retval = retval(:,2:end);
95 endif
Todd
Index: dec2base.m
===================================================================
RCS file: /cvs/octave/scripts/strings/dec2base.m,v
retrieving revision 1.5
diff -c -p -r1.5 dec2base.m
*** a/dec2base.m 27 Jan 2005 17:50:57 -0000 1.5
--- b/dec2base.m 7 Feb 2005 04:55:08 -0000
*************** function retval = dec2base (n, base, len
*** 79,84 ****
--- 79,86 ----
if (nargin == 3)
max_len = max (max_len, len);
+ else
+ len = max_len-1;
endif
## determine digits for each number
*************** function retval = dec2base (n, base, len
*** 90,96 ****
retval = reshape (symbols (digits+1), size (digits));
## Check if the first element is the zero symbol
! if (all (retval(:,1) == symbols(1)))
retval = retval(:,2:end);
endif
--- 92,98 ----
retval = reshape (symbols (digits+1), size (digits));
## Check if the first element is the zero symbol
! if (length(retval(1,:))~= len && all (retval(:,1) == symbols(1)) )
retval = retval(:,2:end);
endif
- make check fails for CVS,
Todd Neal <=