union structures for 64 bit octave

[Clinton Chee]

Hi All,

In the process of checking some 64 bit octave code, I found the use of
some union structures (see below). I've checked the code and don't think
the int in these union structures need to be changed to octave_idx_type.
Can someone confirm this?


in src/unwind-prot.cc

  union
    {
      bool *ptr_to_bool;
      int *ptr_to_int;
      void *gen_ptr;
      void **ptr_to_gen_ptr;
    };

  union
    {
      bool bool_value;
      int int_value;
      const std::string *str_value;
      void *gen_ptr_value;
    };


in src/ov.h

  union
    {
      octave_value *rep;      // The real representation.
      int count;              // A reference count.
    };


Thanks
Clinton


-- 


----------------------------------------------------------------------------
Clinton Chee
Computational Scientist
High Performance Computing Unit
Room 2075, Red Centre
University of New South Wales
Australia 2035
chee at parallel stop hpc stop unsw stop edu stop au
Tel: 61 2 9385 6915
----------------------------------------------------------------------------