|
From: | David Bateman |
Subject: | Re: C++ version of regexprep.cc |
Date: | Wed, 03 May 2006 07:48:36 +0200 |
User-agent: | Thunderbird 1.5 (Windows/20051201) |
John W. Eaton wrote:
Seems to be working from the report from Paul. I'll therefore commit mat2cell, with the corrections you and Tom proposed. Though if it goes in ov-cell.cc, so probably should Fcellfun and Fnum2mat. For this reason I propose to put it in cellfun.cc and you can move it latter if you want.If you agree that this version is working well enough now, then please commit it. Probably it should go in ov-cell.cc. Also, to match all the other doc strings in Octave now, the @seealso line should go just before the @end deftypefn line.
Also, I have a memory leak in the the previous version of regexp I sent due to the fact I use a C like method to create a list and forgot to add a delete method. I intend to std::list instead. Once the memory leak is removed, can I commit it as well?
D.
[Prev in Thread] | Current Thread | [Next in Thread] |