RE: MSVC compiler support [patch 24]: strftime crash

[michael . goffioul]

> For now, I have a special case in configure.in. Can you please checkto make
> sure that liboctave/strftime.c will compile on your system if
> HAVE_STRFTIME is not defined in config.h?
 
It does, but you have to add the following lines to oct-time.cc:

#ifndef HAVE_STRFTIME
/* Just to be sure to override any previous definition and use local version */
extern "C" size_t strftime (char *s, size_t maxsize, const char *format, const struct tm *tp);
#endif

The reason is that without that definition, oct-time.o is somehow "bound" to
the MSVCRT.DLL implementation (I think this is due to the dllimport tag found
in the MSVC headers). The linker then fails because the local strftime clashes
with the one imported from MSVCRT.DLL. The lines above re-defines strftime
without the dllimport tag (you get a warning about it), but at least the linker does
not import the MSVCRT.DLL implementation.
 
Anyway, I think that C++ requires function declaration prior using it. So if a
system does not have strftime, such a declaration is needed, isn't it?
 
Michael.