Re: MSVC compiler support [patch 37]: popen/pclose

[John W. Eaton]

On 26-Oct-2006, Paul Kienzle wrote:

| 
| On Oct 25, 2006, at 10:01 PM, John W. Eaton wrote:
| 
| > On 17-Oct-2006, Michael Goffioul wrote:
| >
| > | popen and pclose are underscored under Win32
| > | Index: src/oct-prcstrm.cc
| > | ===================================================================
| > | RCS file: /cvs/octave/src/oct-prcstrm.cc,v
| > | retrieving revision 1.14
| > | diff -p -c -r1.14 oct-prcstrm.cc
| > | *** src/oct-prcstrm.cc    26 Apr 2005 19:24:33 -0000      1.14
| > | --- src/oct-prcstrm.cc    17 Oct 2006 11:07:42 -0000
| > | *************** Software Foundation, Inc., 51 Franklin S
| > | *** 29,34 ****
| > | --- 29,39 ----
| > |
| > |   #include "oct-prcstrm.h"
| > |
| > | + #ifdef _MSC_VER
| > | + #define popen _popen
| > | + #define pclose _pclose
| > | + #endif
| > | +
| > |   static int
| > |   cxx_pclose (FILE *f)
| > |   {
| >
| > I made this change.  Shouldn't it also be needed for MinGW?
| 
| /mingw/include/stdio.h declares popen.
| 
|       - Paul

OK.  Maybe we need a more global solution rather than including these
defs in multiple files.

jwe