octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New function proposal


From: Michael Goffioul
Subject: Re: New function proposal
Date: Thu, 15 Feb 2007 20:04:42 +0100
User-agent: Thunderbird 1.5.0.9 (Windows/20061207)

David Bateman a écrit :
Ok, I understand the issue... The posix exec family of functions assume
that the first value in the argument list is the command to execute
itself. Therefore, for a command like "sort -nr" execvp in the popen2
posix function should have called execvp with "sort" for the command and
"sort -nr" for the argument list.. The attached patch fixes this and a
couple of other things like a spurious error when killing the child
process when the execvp fails...

I do however see a number of defunct child processes, but that is no
different from the old popen2 function.. I think this patch is good to go..

It looks OK from the MSVC point of view (you added an offset of 1 when building the command line, to take into account the change for execvp). However, the test code should not use double backslash; those were probably introduced by the web mail client I used to send the mail. Use simple backslash, as you do for the POSIX
case.

Michael.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]