Re: New function proposal

[David Bateman]

Michael Goffioul wrote:
> David Bateman a écrit :
>> Ok, I understand the issue... The posix exec family of functions assume
>> that the first value in the argument list is the command to execute
>> itself. Therefore, for a command like "sort -nr" execvp in the popen2
>> posix function should have called execvp with "sort" for the command and
>> "sort -nr" for the argument list.. The attached patch fixes this and a
>> couple of other things like a spurious error when killing the child
>> process when the execvp fails...
>>
>> I do however see a number of defunct child processes, but that is no
>> different from the old popen2 function.. I think this patch is good
>> to go..
>>   
>
> It looks OK from the MSVC point of view (you added an offset of 1 when
> building
> the command line, to take into account the change for execvp).
> However, the test
> code should not use double backslash; those were probably introduced
> by the web
> mail client I used to send the mail. Use simple backslash, as you do
> for the POSIX
> case.
Ok, I'll replace "//" with "/" for the MSVC code..

D.

-- 
David Bateman                                address@hidden
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary