Re: Build fails on current CVS

[John W. Eaton]

On 20-Mar-2007, Daniel J Sebald wrote:

| [bad patch, I'm learning...]
| 
| Daniel J Sebald wrote:
| > Shai Ayal wrote:
| > 
| >> from the Changelog, __lock_globals__ seems to be obsolete.
| >> I got this to work by deleting the reference to __lock_globals__ in 
| >> drawnow.m
| 
| Oh yeah, I see that now.  Hmm.  Well, (John) is there any harm in simply
| making this variable persistent?  The worst that would happen is someone
| would swap out drawnow.m a few times and there'd end up a few
| __go_close_all__() at exit.

I think it is OK if the function is registered multiple times, so
making the variable persistent is probably good enough.

| In the attached patch I've also moved the atexit("__go_close_all__") to
| after the validity of the plot stream is tested.  (Or is there a reason
| to close plots even though they may have not been created exterior to
| Octave?)

I think it only makes sense to close the plot streams if one has been
successfully opened.

I made these changes.

| Also, is there some reason for Octave to use the "persistent" option of
| gnuplot to leave windows open after the end of Octave/gnuplot
| processes?

No.

Thanks,

jwe