octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more graphics changes.


From: John W. Eaton
Subject: Re: more graphics changes.
Date: Tue, 20 Mar 2007 13:18:43 -0400

On 16-Mar-2007, Søren Hauberg wrote:

| *) The "pause" function should call drawnow.
| 
| *) The "text" function doesn't do anything on my system.

I checked in the following chnages for these problems and a similar
potential problem with newplot.

Thanks,

jwe

scripts/ChangeLog:

2007-03-20  John W. Eaton  <address@hidden>

        * plot/newplot.m: Call __request_drawnow__ after initializing axes.
        * plot/text.m: Call __request_drawnow__ after creating text objects.


src/ChangeLog:

2007-03-20  John W. Eaton  <address@hidden>

        * sysdep.cc (Fpause): Call drawnow.


Index: scripts/plot/newplot.m
===================================================================
RCS file: /cvs/octave/scripts/plot/newplot.m,v
retrieving revision 1.6
diff -u -u -r1.6 newplot.m
--- scripts/plot/newplot.m      14 Mar 2007 16:51:29 -0000      1.6
+++ scripts/plot/newplot.m      20 Mar 2007 17:12:00 -0000
@@ -44,6 +44,7 @@
       case "replacechildren"
       case "replace"
        __go_axes_init__ (ca, "replace");
+       __request_drawnow__ ();
       otherwise
        error ("newplot: unrecognized nextplot property for current axes");
     endswitch
Index: scripts/plot/text.m
===================================================================
RCS file: /cvs/octave/scripts/plot/text.m,v
retrieving revision 1.3
diff -u -u -r1.3 text.m
--- scripts/plot/text.m 14 Mar 2007 16:51:29 -0000      1.3
+++ scripts/plot/text.m 20 Mar 2007 17:12:00 -0000
@@ -78,12 +78,14 @@
                                "position", pos(i,:),
                                varargin{:});
        endfor
+       __request_drawnow__ ();
       elseif (n == nx)
        for i = 1:nx
          tmp(i) = __go_text__ (ca, "string", label{i},
                                "position", pos(i,:),
                                varargin{:});
        endfor
+       __request_drawnow__ ();
       else
        error ("text: dimension mismatch for coordinates and label");
       endif
Index: src/sysdep.cc
===================================================================
RCS file: /cvs/octave/src/sysdep.cc,v
retrieving revision 1.124
diff -u -u -r1.124 sysdep.cc
--- src/sysdep.cc       6 Dec 2006 20:23:19 -0000       1.124
+++ src/sysdep.cc       20 Mar 2007 17:12:05 -0000
@@ -84,6 +84,7 @@
 #include "oct-obj.h"
 #include "ov.h"
 #include "pager.h"
+#include "parse.h"
 #include "sighandlers.h"
 #include "sysdep.h"
 #include "toplev.h"
@@ -648,15 +649,20 @@
 
       if (! error_state)
        {
-         if (xisnan (dval))
-           warning ("pause: NaN is an invalid delay");
-         else if (xisinf (dval))
+         if (! xisnan (dval))
            {
-             flush_octave_stdout ();
-             octave_kbhit ();
+             feval ("drawnow");
+
+             if (xisinf (dval))
+               {
+                 flush_octave_stdout ();
+                 octave_kbhit ();
+               }
+             else
+               octave_sleep (dval);
            }
          else
-           octave_sleep (dval);
+           warning ("pause: NaN is an invalid delay");
        }
     }
   else

reply via email to

[Prev in Thread] Current Thread [Next in Thread]