octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch to hist for changes in bar


From: David Bateman
Subject: Re: Patch to hist for changes in bar
Date: Thu, 26 Apr 2007 01:07:07 +0200
User-agent: Thunderbird 1.5.0.7 (X11/20060921)

John W. Eaton wrote:
> On 25-Apr-2007, David Bateman wrote:
> 
> | The default bar width in hist is 0.8 and so the bars don't touch. The
> | old behavior of hist was that the bar width of 1.0 should be used. The
> | 1.0 is the width of the bar.. Compare "bar(1:10,1:10)" against
> | "bar(1:10,1:10,1.0)". It looks like the error you are seeing is in fact
> | due to a small error in __bar__.m in that non string arguments or cell
> | arrays should not be passed to __pltopt__. There was also an issue with
> | the previous patch as hist(randn(1e6,1)) for example returned the figure
> | handle even if nargout was zero.
> 
> OK.  Please check this in.
> 
> You might also change
> 
> |     else
> | !     if (nargout == 1)
> | !       nn = bar (x, freq, 1.0);
> | !     else
> | !       bar (x, freq, 1.0);
> | !     endif
> |     endif
> 
> to be just
> 
>   elseif (nargout == 1)
>     ..
>   else
>     ..
>   endif
> 
> Thanks,
> 

Done..

D.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]