Re: MSVC patch: s/INVALID_FILE_HANDLE/INVALID_HANDLE_VALUE/g

[Benjamin Lindner]

> INVALID_FILE_HANDLE is not part of the Win32 API (at least for VCExpress
> 2005).
> 
> Index: src/sysdep.cc
> ===================================================================
> RCS file: /cvs/octave/src/sysdep.cc,v
> retrieving revision 1.127
> diff -c -p -c -r1.127 sysdep.cc
> *** src/sysdep.cc       27 Apr 2007 17:34:28 -0000      1.127
> --- src/sysdep.cc       25 May 2007 09:13:06 -0000
> *************** same_file_internal (const std::string& f
> *** 244,256 ****
>     hfile1 = CreateFile (file1.c_str (), 0, FILE_SHARE_READ, 0,
>                        OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
> 
> !   if (hfile1 == INVALID_FILE_HANDLE)
>       return false;
> 
>     hfile2 = CreateFile (file2.c_str (), 0, FILE_SHARE_READ, 0,
>                        OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
> 
> !   if (hfile2 == INVALID_FILE_HANDLE)
>       {
>         CloseHandle (hfile1);
>         return false;
> --- 244,256 ----
>     hfile1 = CreateFile (file1.c_str (), 0, FILE_SHARE_READ, 0,
>                        OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
> 
> !   if (hfile1 == INVALID_HANDLE_VALUE)
>       return false;
> 
>     hfile2 = CreateFile (file2.c_str (), 0, FILE_SHARE_READ, 0,
>                        OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
> 
> !   if (hfile2 == INVALID_HANDLE_VALUE)
>       {
>         CloseHandle (hfile1);
>         return false;

Oops, sorry, my fault.
I didn't have VC when testing, only cygwins's gcc and there this 
compiled fine, strangely .

benjamin

-- 
GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS.
Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail