octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

wrong use of color_property in patch.facecolor


From: Shai Ayal
Subject: wrong use of color_property in patch.facecolor
Date: Sat, 29 Sep 2007 22:39:47 +0200

Hi

I noticed a wrong use for setting the color property. It relates to
the problems we discussed on setting radio_value based properties.

the property is patch.facecolor. The way it should have been
implemented is using the attached patch. Note that this way avoids the
duplication of the allowed radio_values both in
patch::properties::properties and in patch::properties::set by using
the "a" modifier in the property declaration

It also eliminates the need to change
color_property::color_property(const octave_value&).

Shai

2007-09-29  Shai Ayal  <address@hidden>

        * graphics.cc ((color_property::color_property (const
        octave_value& val)): Undo change from 2007-09-26
        (patch::properties::properties): use the "a" modifier to
        face_color & edge_color properties
        (patch::properties::set): Undo change from 2007-09-26
        * graphics.h.in (color_property::color_property
        (const octave_value& val)): Undo change from 2007-09-26

Attachment: patch_facecolor.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]