Re: Small change to pkg.m?

[Thomas Treichl]

David Bateman schrieb:
> I don't see how this might break things, and seems the right thing to
> do.. I might also suggest respecting any variables from the environment
> so that your original trick would also work.. Something like
>
> flags = "";
> if (isempty (getenv ("CC")))
>   flags = strcat (flags,
>   " CC =\"", mkoctfile ("-p", "CC"), "\"");
> endif
> if (isempty (getenv ("CXX")))
>   flags = strcat (flags,
>   " CXX =\"", mkoctfile ("-p", "CXX"), "\"");
> endif
> if (isempty (getenv ("AR")))
>   flags = strcat (flags,
>   " AR =\"", mkoctfile ("-p", "AR"), "\"");
> endif
> if (isempty (getenv ("RANLIB")))
>   flags = strcat (flags,
>   " RANLIB =\"", mkoctfile ("-p", "RANLIB"), "\"");
> endif
> [status, output] = shell (strcat ("cd ", src, "; ./configure --prefix=\"",
>     desc.dir, "\"", flags, "\""));
>
> Want to supply a patch?
>
> D.

Thanks for the quick answer David,

just some questions before I prepare a patch, mkoctfile uses these lines

  : ${CC="gcc ..."}
  : ${CXX="g++ ..."}

do we really need to check

  if (isempty (getenv ("CC")))

then?

mkoctfile does not have fields for AR and RANLIB, so I think I shouldn't ask 
mkoctfile for the values of AR and RANLIB?

  Thomas