octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MSCV patch: fix problem with "system" and the weird double quote han


From: Michael Goffioul
Subject: Re: MSCV patch: fix problem with "system" and the weird double quote handling of Win32
Date: Tue, 6 Nov 2007 16:24:14 +0100

On 11/4/07, Michael Goffioul <address@hidden> wrote:
> src/ChangeLog:
>
> 2007-11-04  Michael Goffioul <address@hidden>
>
>    * toplev.cc: quote the complete command to execute in
>    system function to work around weird double-quote handling
>    of Win32 platform.

The previous patch breaks behavior in async mode. Here's a
corrected one.

Michael.

Index: src/toplev.cc
===================================================================
RCS file: /cvs/octave/src/toplev.cc,v
retrieving revision 1.206
diff -c -r1.206 toplev.cc
*** src/toplev.cc       12 Oct 2007 21:27:34 -0000      1.206
--- src/toplev.cc       6 Nov 2007 14:44:22 -0000
***************
*** 531,536 ****
--- 531,541 ----

        if (! error_state)
        {
+ #if defined (__WIN32__) && ! defined (__CYGWIN__)
+           if (type == et_sync)
+             cmd_str = "\"" + cmd_str + "\"";
+ #endif
+
          if (type == et_async)
            {
              // FIXME -- maybe this should go in sysdep.cc?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]