octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: improved surface: __go_draw_axes__


From: David Bateman
Subject: Re: improved surface: __go_draw_axes__
Date: Wed, 07 Nov 2007 01:22:03 +0100
User-agent: Thunderbird 1.5.0.7 (X11/20060921)

John W. Eaton wrote:
> On  5-Nov-2007, Kai Habel wrote:
> 
> | John W. Eaton schrieb:
> | > On  4-Nov-2007, Kai Habel wrote:
> | >
> | > | I had to apply my changes to __go_draw_axes__.m manually, without the
> | > | possibility to check it now (I am recompiling now). So, there is a good
> | > | chance that something went wrong. I will check tomorrow and repost if
> | > | needed.
> | > | 
> | > | Kai
> | > | 
> | > | 2007-11-04  Kai Habel  <address@hidden>
> | > | 
> | > |   * plot/__go_draw_axes__.m: Use pm3d mode for surface now
> | >
> | > I don't think you have posted this yet.
> | >
> | > Please send all the new files adn the patches for graphics.{cc,h.in}
> | > and __go_draw_axes__.m in a single message.  Once you've done that,
> | > I'll take a look it.
> | >
> | > Thanks,
> | >
> | > jwe
> | >
> | >   
> | 
> | Hello,
> | 
> | I have addressed Michael G. comment about drawnow in shading, it seems
> | this is not needed. In addition the __go_draw_axes__.m patch is now
> | included (the version it sent to jwe accidentally had a small error).
> | 
> | Here are all files.
> | 
> | Kai
> | 
> | 2007-11-05  Kai Habel  <address@hidden>
> | 
> |   * plot/__go_draw_axes__.m: Use pm3d mode for surface now
> |   * plot/shading.m: New function
> |   * plot/surface.m: New function
> |   * plot/mesh.m: Calls now surface.m
> |   * plot/pcolor.m: New function
> |   * plot/surf.m: New function
> | 
> | 
> | 2007-11-05  Kai Habel  <address@hidden>
> | 
> |   * graphics.h.in (class surface): Add properties for surface, mash,
> |   and cdata.
> |   * graphics.cc (surface::properties::properties): Initialize added
> | properties.
> |   (surface::properties::set): Set added properties. Fix cut and paste
> |   error for facealpha.
> |   (surface::properties::get): Get added properties.
> |   (surface::properties::factory_defaults): Set added properties.
> 
> I checked in the changes to graphics.cc and graphics.h.in.
> 
> After applying the patch to plot/__go_draw_axes__.m and putting the
> other new files in place, I noticed
> 
>   octave:1> sombrero
>   error: `c' undefined near line 91 column 74
>   error: evaluating argument list element number 9
>   error: evaluating assignment expression near line 91, column 7
>   error: called from `surface' in file 
> `/home/jwe/src/octave-trunk/scripts/plot/surface.m'
>   error: evaluating assignment expression near line 37, column 7
>   error: called from `mesh' in file 
> `/home/jwe/src/octave-trunk/scripts/plot/mesh.m'
>   error: evaluating if command near line 47, column 7
>   error: evaluating if command near line 42, column 5
>   error: evaluating if command near line 41, column 3
>   error: called from `sombrero' in file 
> `/home/jwe/src/octave-trunk/scripts/plot/sombrero.m'
> 
> so I moved the statement setting c = z for the nargin == 3 case.
> 
> With this patch, is it possible to use gnuplot 4.0 to plot surfaces at
> all, or is it absolutely required now to have gnuplot 4.2?  I'd check,
> but I don't currently have a copy of 4.0 installed on my system.
> 
> Thanks,
> 
> jwe
> 

Can we move surfc from octave-forge as well? I'll check against gnuplot
4.0 as I've deliberately kept it installed to check compatibility.

D.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]