Re: problems building 2.9.17+ from CVS; surface.m implicated

[David Bateman]

Joseph P. Skudlarek wrote:
> I tried a second build of Octave from CVS sources (having just done an
> update), and I'm seeing this consistent failure.
> 
>     ../../run-octave -f -q -H -p . --eval "interpimages ('interpn', 'eps'); 
> sleep (1);"
>     error: surface::defaults: not implemented
>     error: called from `surface' in file 
> `/usr/local/src/octave-cvs/octave/scripts/plot/surface.m'
>     error: evaluating assignment expression near line 37, column 7
>     error: called from `mesh' in file 
> `/usr/local/src/octave-cvs/octave/scripts/plot/mesh.m'
>     error: evaluating if command near line 21, column 3
>     error: called from `interpimages' in file 
> `/usr/local/src/octave-cvs/octave/doc/interpreter/interpimages.m'
>     make[3]: *** [interpn.eps] Error 1
>     make[3]: Leaving directory 
> `/usr/local/src/octave-cvs/octave/doc/interpreter'
>     make[2]: *** [interpreter] Error 2
>     make[2]: Leaving directory `/usr/local/src/octave-cvs/octave/doc'
>     make[1]: *** [doc] Error 2
>     make[1]: Leaving directory `/usr/local/src/octave-cvs/octave'
>     make: *** [all] Error 2
> 
> FYI, I also saw these messages on the first build attempt; the plot.texi
> warnings did not show up on the second build attempt after update (with
> no noticed updates).
> 
>     makeinfo -I.. -I. -I./.. ./octave.texi
>     .//plot.texi:68: warning: @image file `plot.txt' (for text) unreadable: 
> No such file or directory.
>     .//plot.texi:311: warning: @image file `hist.txt' (for text) unreadable: 
> No such file or directory.
>     .//plot.texi:587: warning: @image file `errorbar.txt' (for text) 
> unreadable: No such file or directory.
>     .//plot.texi:749: warning: @image file `polar.txt' (for text) unreadable: 
> No such file or directory.
>     .//plot.texi:984: warning: @image file `mesh.txt' (for text) unreadable: 
> No such file or directory.
>     .//plot.texi:1007: warning: @image file `plot3.txt' (for text) 
> unreadable: No such file or directory.
>     ../../run-octave -f -q -H -p . --eval "sparseimages ('gplot', 'eps'); 
> sleep (1);"
>     if [ -f gplot.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=gplot.pdf gplot.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "sparseimages ('grid', 'eps'); 
> sleep (1);"
>     Notice: No surface grid anything could be hidden behind
>     if [ -f grid.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=grid.pdf grid.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "sparseimages ('spmatrix', 'eps'); 
> sleep (1);"
>     if [ -f spmatrix.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=spmatrix.pdf spmatrix.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "sparseimages ('spchol', 'eps'); 
> sleep (1);"
>     if [ -f spchol.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=spchol.pdf spchol.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "sparseimages ('spcholperm', 
> 'eps'); sleep (1);"
>     if [ -f spcholperm.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=spcholperm.pdf spcholperm.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "interpimages ('interpft', 'eps'); 
> sleep (1);"
>     if [ -f interpft.eps ] ; then gs -dBATCH -dEPSCrop -dNOPAUSE -q 
> -sDEVICE=pdfwrite -sOutputFile=interpft.pdf interpft.eps ; fi
>     ../../run-octave -f -q -H -p . --eval "interpimages ('interpn', 'eps'); 
> sleep (1);"
>     error: surface::defaults: not implemented
>     error: called from `surface' in file 
> `/usr/local/src/octave-cvs/octave/scripts/plot/surface.m'
>     error: evaluating assignment expression near line 37, column 7
>     error: called from `mesh' in file 
> `/usr/local/src/octave-cvs/octave/scripts/plot/mesh.m'
>     error: evaluating if command near line 21, column 3
>     error: called from `interpimages' in file 
> `/usr/local/src/octave-cvs/octave/doc/interpreter/interpimages.m'
>     make[3]: *** [interpn.eps] Error 1
>     make[3]: Leaving directory 
> `/usr/local/src/octave-cvs/octave/doc/interpreter'
>     make[2]: *** [interpreter] Error 2
>     make[2]: Leaving directory `/usr/local/src/octave-cvs/octave/doc'
>     make[1]: *** [doc] Error 2
>     make[1]: Leaving directory `/usr/local/src/octave-cvs/octave'
>     make: *** [all] Error 2
> 
> FYI.  /J
> 



The fix for it is in the patch I sent earlier and is basically

*** ./scripts/plot/surface.m.orig9      2007-11-15 11:08:30.132649857 +0100
--- ./scripts/plot/surface.m    2007-11-15 11:07:34.522414956 +0100
***************
*** 123,129 ****
    ## Make a default surface object.
    tmp = __go_surface__ (ax, "xdata", x, "ydata", y, "zdata", z,
"cdata", c);
    set (tmp, "facecolor","flat");
!   set (tmp, varargin {firststring:end});

    if (! ishold ())
      set (ax, "view", [0, 90], "box", "off", "xgrid", "on", "ygrid",
"on", "zgrid", "on");
--- 123,131 ----
    ## Make a default surface object.
    tmp = __go_surface__ (ax, "xdata", x, "ydata", y, "zdata", z,
"cdata", c);
    set (tmp, "facecolor","flat");
!   if (firststring <= nargin)
!     set (tmp, varargin {firststring:end});
!   endif

    if (! ishold ())
      set (ax, "view", [0, 90], "box", "off", "xgrid", "on", "ygrid",
"on", "zgrid", "on");

D.