octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: conversion of octave_int<short int> to int? moved from help-octave


From: Moritz Borgmann
Subject: Re: conversion of octave_int<short int> to int? moved from help-octave
Date: Tue, 27 Nov 2007 22:18:03 +0100

thanks for implementing this. Yes, I checked today and it compiles fine. We're getting closer to a Sun Studio build I guess.

My Solaris build adventure is now stuck in some template-related linker errors. Will drill down further and possibly consult the list later on with details.

Thanks again,

Moritz

I checked in the following change instead of removing the new
conversion operator.  Does it work for you with the Solaris compiler?

jwe



liboctave/ChangeLog:

2007-11-26  John W. Eaton  <address@hidden>

        * idx-vector.h (idx_vector::idx_vector_rep (const intNDArray<U>&)):
        Eliminate unnecessary second arg from call to tree_to_mat_idx.

        * oct-inttypes.h (operator bool, operator char): Delete.
        (bool_value, char_value, double_value, float_value): New functions.


src/ChangeLog:

2007-11-26  John W. Eaton  <address@hidden>

        * oct-stream.cc (do_write): Call float_value and double_value on
        octave_int<T> objects instead of relying on conversion operators.

        * ls-mat5.cc (read_mat5_binary_element, OCTAVE_MAT5_INTEGER_READ):
        Call double_value on octave_int<T> objects
        instead of relying on conversion operator.
        (read_mat5_binary_file_header):
        Call char_value on octave_int<T> objects
        instead of relying on conversion operator.
        (read_mat5_binary_element):
        Call bool_value on octave_int<T> objects
        instead of relying on conversion operator.

        * ov-intx.h (OCTAVE_VALUE_INT_MATRIX_T::double_value,
        OCTAVE_VALUE_INT_MATRIX_T::scalar_value,
        OCTAVE_VALUE_INT_MATRIX_T::matrix_value,
        OCTAVE_VALUE_INT_MATRIX_T::complex_matrix_value,
        OCTAVE_VALUE_INT_MATRIX_T::array_value,
        OCTAVE_VALUE_INT_MATRIX_T::complex_array_value,
        OCTAVE_VALUE_INT_SCALAR_T::double_value,
        OCTAVE_VALUE_INT_SCALAR_T::scalar_value,
        OCTAVE_VALUE_INT_SCALAR_T::matrix_value,
        OCTAVE_VALUE_INT_SCALAR_T::complex_matrix_value,
        OCTAVE_VALUE_INT_SCALAR_T::array_value,
        OCTAVE_VALUE_INT_SCALAR_T::complex_array_value,
        Call double_value on octave_int<T> objects
        instead of relying on conversion operator.
        (OCTAVE_VALUE_INT_MATRIX_T::bool_array_value,
        OCTAVE_VALUE_INT_SCALAR_T::bool_array_value):
        Call bool_value on octave_int<T> objects
        instead of relying on conversion operator.
        (OCTAVE_VALUE_INT_MATRIX_T::char_array_value,
        OCTAVE_VALUE_INT_SCALAR_T::char_array_value):
        Call char_value on octave_int<T> objects
        instead of relying on conversion operator.


Index: liboctave/idx-vector.h
===================================================================
RCS file: /cvs/octave/liboctave/idx-vector.h,v
retrieving revision 1.53
diff -u -u -r1.53 idx-vector.h
--- liboctave/idx-vector.h      12 Oct 2007 21:27:16 -0000      1.53
+++ liboctave/idx-vector.h      27 Nov 2007 02:54:54 -0000
@@ -74,13 +74,8 @@
[snip]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]