Re: Graphics properties implementation

[John W. Eaton]

On 13-Jan-2008, Kai Habel wrote:

| Kai Habel schrieb:
| > Shai Ayal schrieb:
| >   
| >> OK, it seems like it's time to start adding properties.
| >> Michael, Just so we don't duplicate our work, Do you plan on adding
| >> other properties soon or will you focus on the backend?
| >> If you are planning to add, lets divide the work -- tell me what you
| >> want to add, and I'll do the rest
| >>
| >> Shai
| >>
| >> On Jan 12, 2008 2:06 PM, Michael Goffioul <address@hidden> wrote:
| >>   
| >>     
| >>> On 1/12/08, John W. Eaton <address@hidden> wrote:
| >>>     
| >>>       
| >>>> OK, I applied the patch and checked it in.
| >>>>       
| >>>>         
| >>> Please also consider the attached patch. It add missing values to
| >>> xaxislocation and yaxislocation properties and export some symbols
| >>> (this allows development of external backends and allow me to test
| >>> my rendering code outside of octave).
| >>>
| >>> Michael.
| >>>
| >>>     
| >>>       
| >>   
| >>     
| > Hello all,
| >
| > to divide the work, I could start adding properties for the patch object
| > over the weekend. After that I plan to add the light object.
| >
| > Kai
| >
| >   
| Hello all,
| 
| here is a patch to add missing patch properties.
| But have a question:
| 
| I am not sure when to use the 'a' qualifier for radio properties.
| Michael has used both versions for the patch object e.g.:
| 
| ...
| radio_property linestyle , "{-}|--|:|-.|none"
| ...
| radio_property interpreter a , "{tex}|none|latex"
| 
| 
| For the new radio properties ones I have always used the 'a' qualifier,
| but is this ok?

I applied your patch and checked it in with the following ChangeLog
entry:

  2008-01-14  Kai Habel  <address@hidden>

          * graphics.h.in (class patch::properties): New properties,
          cdatamapping, facevertexalphadata, facevertexcdata, vertexnormals,
          normalmode, facelighting, edgealpha, edgelighting,
          backfacelighting, ambientstrength, diffusestrength,
          specularstrength, specularexponent, specularcolorreflectance,
          erasemode.

Your added properties were indented with 3 tabs but the surrounding
properties are inented 6 spaces.  Are you using a non-standard tab
setting (i.e., not 8-spaces)?  If so, I'd recommend not doing that
since others have no idea what tab setting you are using, so it is
hard for the rest of us to read.

Thanks,

jwe