[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Making sort a method of Array<T>, Sparse<T> and octave_value classes
From: |
John W. Eaton |
Subject: |
Re: Making sort a method of Array<T>, Sparse<T> and octave_value classes |
Date: |
Thu, 31 Jan 2008 04:21:33 -0500 |
On 31-Jan-2008, David Bateman wrote:
| I see no reason not to do, but there are many ways to do it, and maybe
| you don't agree with the one I picked.. Since if this patch is accepted
| it'll be the model for how the others are converted to behave in a
| similar manner it makes sense to get the way its implemented to be the
| closest to what you'd like to see.
It seems OK to me.
One thing I don't quite get is the purpose of NO_INSTANTIATE_ARRAY_SORT.
| Note that I have a new version of this patch that adds tests for cell
| string arrays and int -> octave_idx_type changes in oct-sort.{cc,h} for
| 64-bit platforms, though that doesn't change the basic idea of the patch
| and so I won't send it to the list to avoid mail bombing everyone.
If you think it is complete (or close), then please check it in.
Thanks,
jwe