octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Polyfit with scaling


From: Ben Abbott
Subject: Re: Polyfit with scaling
Date: Mon, 04 Feb 2008 15:11:01 -0800

On Monday, February 04, 2008, at 04:21PM, "Dmitri A. Sergatskov" 
<address@hidden> wrote:
>Looks good, though i have a couple minor comments:
>
>-- if std(x) == 0 then it means that all x are the same number (I
>would also argue that one
>    may want to compare to eps rather than 0). In that case we cannot
>do any fits,
>    so probaly should just exit with an error.
>
>-- I really do not like have variables that different only in
>capitalization: x and X in this code.
>    I would rename X to XX or something. But this is matter of taste
>and I would leave it to
>    jwe to have the final say.
>

I agree. I hadn't got around to changing that.

Ben


reply via email to

[Prev in Thread] Current Thread [Next in Thread]