Re: Implementation of convn

[John W. Eaton]

On 24-Mar-2008, Søren Hauberg wrote:

| man, 24 03 2008 kl. 17:56 -0400, skrev John W. Eaton:
| > On 24-Mar-2008, Søren Hauberg wrote:
| > 
| > | man, 24 03 2008 kl. 16:27 -0400, skrev John W. Eaton:
| > | > Will you please update according to the following comments and submit
| > | > this as an hg changeset?
| > | 
| > | Sure. In which directories do you want the files to be placed?
| > 
| > I suppose it should go with conv.m in scripts/polynomial.
| Okay, and I put __convn__.cc in src/DLD-FUNCTIONS.

Applying this changeset with

  hg qimport convn
  hg qpush

failed with the message

  patch failed, unable to continue (try -v)
  patch failed, rejects left in working dir
  Errors during apply, please fix and refresh convn

and the new file __convn__.cc was not created.  Did you "hg add" it?

If not, please do that before committing and exporting the changeset.
If you did add, then can you try exporting the changeset again with

  hg export -g

I'd recommend adding

  [diff]
  git = 1

to your ~/.hgrc file so that this is the default.  That way,
changesets will properly track renamed files.


# HG changeset patch
# User address@hidden
# Date 1206397313 -3600
# Node ID 87b52a332769a83a519ba4f1460b81d445cb8df0
# Parent  205e43d9d9da89a3841c9e669969aa4f5b7d2a10
Added support for N-dimensional convolution

diff -r 205e43d9d9da -r 87b52a332769 ChangeLog
--- a/ChangeLog Sat Mar 22 14:59:41 2008 +0100
+++ b/ChangeLog Mon Mar 24 23:21:53 2008 +0100
@@ -1,3 +1,10 @@ 2008-03-21  David Bateman  <address@hidden
+2008-03-24  Soren Hauberg  <address@hidden>
+
+       * src/DLD-FUNCTIONS/__convn__.cc: new file that implements the 'heavy
+         lifting' of N-dimensional convolution.
+       * scripts/polynomial/convn.m: new function for N-dimensional 
convolution.
+       * src/Makefile.in: add __convn__.cc to DLD_XSRC.

There are separate ChangeLog files in the src and scripts directories,
so please use those.  Also, for new files, it is sufficient to just
say "New file."  There is no need to explain the purpose in the
ChangeLog.

Thanks,

jwe