octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Problem exporting symbols in pt-idx.h


From: John W. Eaton
Subject: Problem exporting symbols in pt-idx.h
Date: Wed, 21 May 2008 08:42:50 -0400

On 21-May-2008, Michael Goffioul wrote:

| While trying to decorate some classes with OCTINTERP_API, I found
| a compilation problem with MSVC in pt-idx.h, where it can't decide
| which default constructor to use for tree_index_expression. Indeed,
| there are 2 versions of ctor where all arguments have a default values:
| a public one and a private one. This hasn't been a problem until now,
| because the class was not exported.

Does this change fix the problem for you?

jwe

# HG changeset patch
# User John W. Eaton <address@hidden>
# Date 1211373540 14400
# Node ID c23fab029f46704883e9ffcff15aea5b15f8a199
# Parent  82be108cc5583e5ddef84f8948825bb96f43d2af
tree_index_expression constructor: delete default arg values

diff --git a/src/ChangeLog b/src/ChangeLog
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2008-05-21  John W. Eaton  <address@hidden>
+
+       * pt-idx.h (tree_index_expression::tree_index_expression (int, int)): 
+       Delete default argument values.
+
 2008-05-20  David Bateman  <address@hidden>
 
        * data.cc (Flog2): Handle single precision.
diff --git a/src/pt-idx.cc b/src/pt-idx.cc
--- a/src/pt-idx.cc
+++ b/src/pt-idx.cc
@@ -43,7 +43,7 @@
 // Index expressions.
 
 tree_index_expression::tree_index_expression (int l, int c)
-  : tree_expression (l, c), expr (), args (), type (),
+  : tree_expression (l, c), expr (0), args (), type (),
     arg_nm (), dyn_field () { }
 
 tree_index_expression::tree_index_expression (tree_expression *e,
diff --git a/src/pt-idx.h b/src/pt-idx.h
--- a/src/pt-idx.h
+++ b/src/pt-idx.h
@@ -113,7 +113,7 @@
   // The list of dynamic field names, if any.
   std::list<tree_expression *> dyn_field;
 
-  tree_index_expression (int l = -1, int c = -1);
+  tree_index_expression (int l, int c);
 
   Octave_map make_arg_struct (void) const;
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]