octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Changeset] Re: Single Precision versus double precision NA


From: John W. Eaton
Subject: [Changeset] Re: Single Precision versus double precision NA
Date: Thu, 05 Jun 2008 18:24:30 -0400

On  5-Jun-2008, David Bateman wrote:

| Ok, then the attached changeset addresses this by changing the NA values
| as above. I still have no confirmation that the above code worked as
| expected for other machines than my own. However I added a couple of
| tests that check that the translation of NA values from single to double
| precision and visa-versa is done correctly and so if make check is run
| on different systems we'll quickly find if there is an issue with this
| change. I also added code to data-conv.cc (read_doubles) to check for
| the old NA value and convert it to the new one. So there is forward
| compatibility for the NA values saved with older versions of Octave.
| However, NA values saved after this change won't be loaded correctly
| with older version of Octave. In any case if the conversion in this
| changeset works correctly for other platforms, OS and compilers then
| this is probably the simplest way to address this issue.

With this change will a binary file of double-precision values
containing some NA values and written by Octave still be readable by
R with the NA values preserved?

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]