[Changeset]: Re: Compilation problem: xacosh missing/typo?

[David Bateman]

Michael Goffioul wrote:
> With a fresh update of octave HG, I get a compilation error
> in liboctave, because of undefined reference of _xacosh_.
> Looking into libcruft/slatec-fn/xacosh.f, it appears the name
> of the subroutine is defined as "xsacosh". Is this a typo?
>
> Michael.
>
>   
Yes this is a typo when I was replacing double precision slatec
functions with single precision versions (ie xdacosh in this case) and
before I'd downloaded the new functions from netlib. The attached
changeset addresses this

D.


-- 
David Bateman                                address@hidden
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary

# HG changeset patch
# User David Bateman <address@hidden>
# Date 1213603755 -7200
# Node ID 1bb8e965e5b5547877f98869bda37935f20399d1
# Parent  7a7247ccd9626bc0bc5f8f5d7041063442f04cb0
Fix to use of single precision slatec functions

diff --git a/libcruft/ChangeLog b/libcruft/ChangeLog
--- a/libcruft/ChangeLog
+++ b/libcruft/ChangeLog
@@ -1,3 +1,8 @@ 2008-06-12  Jaroslav Hajek <address@hidden
+2008-06-16  David Bateman  <address@hidden>
+
+       * slatec-fn/xacosh.f, slatec-fn/xasinh.f: Replace xsacosh with
+       xacosh, xdacosh with xacosh and xdasinh with xasinh.
+
 2008-06-12  Jaroslav Hajek <address@hidden>
 
        * misc/Makefile.in (MAKEDEPS): Remove CEXTRA.
diff --git a/libcruft/slatec-fn/xacosh.f b/libcruft/slatec-fn/xacosh.f
--- a/libcruft/slatec-fn/xacosh.f
+++ b/libcruft/slatec-fn/xacosh.f
@@ -1,6 +1,6 @@
-      subroutine xsacosh (x, result)
+      subroutine xacosh (x, result)
       external acosh
-      real x, result, dacosh
+      real x, result, acosh
       result = acosh (x)
       return
       end
diff --git a/libcruft/slatec-fn/xasinh.f b/libcruft/slatec-fn/xasinh.f
--- a/libcruft/slatec-fn/xasinh.f
+++ b/libcruft/slatec-fn/xasinh.f
@@ -1,6 +1,6 @@
       subroutine xasinh (x, result)
       external asinh
-      real x, result, dasinh
+      real x, result, asinh
       result = asinh (x)
       return
       end