octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MSVC compilation fixes


From: Michael Goffioul
Subject: Re: MSVC compilation fixes
Date: Thu, 10 Jul 2008 12:29:15 +0200

On Wed, Jul 9, 2008 at 5:10 PM, John W. Eaton <address@hidden> wrote:
> diff -r 7683fa6c06a2 src/OPERATORS/op-int.h
> --- a/src/OPERATORS/op-int.h    Mon Feb 11 10:11:56 2008 +0100
> +++ b/src/OPERATORS/op-int.h    Fri Jun 20 12:40:27 2008 +0200
> @@ -227,13 +227,13 @@
>   octave_value \
>   xpow (const octave_ ## T1& a, float b) \
>   { \
> -    return pow (a, b); \
> +    return pow (a, static_cast<double> (b)); \
>   } \
>
> Shouldn't we use powf here instead?  Does MSVC provide powf, or do we
> need a replacement in lo-specfun.cc (or lo-mappers.cc; I'm not sure
> now why these files aren't combined)?

Maybe David should comment on it. MSVC has powf
(but it simply defined to (float)pow(a,b) on non-64bits architectures)).

Michael.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]