|
From: | Ben Abbott |
Subject: | Re: [changeset] property value not paired with name in __add_datasource__.m |
Date: | Mon, 01 Sep 2008 09:06:11 -0400 |
On Sep 1, 2008, at 6:30 AM, David Bateman wrote:
This is not the correct fix as __add_datasource__ is looking for a prop/val pair with the name ?DataSource. It doesn't however make the assumption that the other arguments that are passed are all property/ value pairs, and in some cases they are.Trying to generate or error with plot(1:10,1:10,"LineWidth", 3)the code works correctly. I then tried a rebuild of voroni.eps with the changeset I just sent and the build when find. I'd therefore suggest not making the change to __add_datasource__ you suggest..Regards David
octave:1> plot(1:10,1:10,"LineWidth", 3) error: set: invalid number of arguments error: called from:error: /Users/bpabbott/Development/mercurial/octave-3-0-0/scripts/ plot/__plt2vv__.m at line 83, column 7 error: /Users/bpabbott/Development/mercurial/octave-3-0-0/scripts/ plot/__plt2__.m at line 68, column 14 error: /Users/bpabbott/Development/mercurial/octave-3-0-0/scripts/ plot/__plt__.m at line 79, column 10 error: /Users/bpabbott/Development/mercurial/octave-3-0-0/scripts/ plot/plot.m at line 189, column 5
The problem appears to remains.
I identified the problem is in __plt2vv__.m [...] 69 hg = hggroup (); 70 retval = hg;71 properties = __add_datasource__ ("__plt2vv__", hg, {"x", "y", "z"},72 properties{:}); 73 74 h = line (x, y, "keylabel", key, "color", color, 75 "linestyle", options.linestyle, 76 "marker", options.marker, "parent", hg); 77 78 __add_line_series__ (h, hg); 79 if (! isempty (properties)) 80 set (hg, properties{:}); 81 endif Prior to line 71"properties" is set as { [1,1] = LineWidth [1,2] = 3 } Subsequently, "properties is set as { [1,1] = LineWidth }
The scripts __add_datasource__ does not preserve the property values.I'm confused as to how __add_datasource__ is intended to work. Is this behavior correct?
If yours works properly (different, I assume), perhaps our sources are out of sync?
Beb Ben
[Prev in Thread] | Current Thread | [Next in Thread] |