Re: 3.0.3 release candidate

[Tatsuro MATSUOKA]

Hello

--- Jaroslav Hajek <address@hidden> wrote:
> the release candidate tarballs for octave 3.0.3 can be found at
> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
> Anyone is welcome to build and report results.

I have tested on mingw and propose two changeset.


*********
--- a/src/DLD-FUNCTIONS/rand.cc Mon Aug 04 22:32:47 2008 -0400 
+++ b/src/DLD-FUNCTIONS/rand.cc Fri Aug 08 16:11:07 2008 +0900 
@@ -950,7 +950,7 @@ 
 %!test 
 %! % Test fixed state 
 %! randp("seed",1); 
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6) 
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e+2) 
 %!test 
 %! if (__random_statistical_tests__) 
 %!   % statistical tests may fail occasionally.

*************
--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400 
+++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900 
@@ -1,3 +1,7 @@ 
+2008-08-22  Tatsuro MATSUOKA  <address@hidden> 
+ 
+       test/octave.test/string/isprint-1.m in test_string.m for fixed. 
+ 
 2008-08-19  Jaroslav Hajek <address@hidden> 
  
        Version 3.0.2 released. 
diff -r 4908e39553b0 test/test_string.m 
--- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400 
+++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900 
@@ -532,7 +532,7 @@ 
 %! result = zeros (1, 128); 
 %! 
 %! result (33:127) = 1; 
-%! if (ispc () && ! isunix ()) 
+%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2)) 
 %!   result(10) = 1; 
 %! endif 
 %!

************
The make check errors No.2 and No.3 were discussed by Benjamin but they seemed 
to be unsolved even 
now.

http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2008-August/008155.html

Regards

Tatsuro


********test Reults
$ make check
Integrated test scripts:
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\src/DLD-FUNCTIONS\rand.cc  PASS
56/57   FAIL 1
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\src\ov-fcn-handle.cc  PASS    2/3
   FAIL 1
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\scripts/strings\mat2str.m  PASS
 2/3    FAIL 1

Fixed test scripts:

  test_string.m .......................................... PASS  130/131  FAIL 1

Summary:

  PASS   3869
  FAIL      4

*********
1
*********
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\src/DLD-FUNCTIONS\rand.cc  PASS
56/57   FAIL 1
  ***** test
 % Test fixed state
 randp("seed",1);
 assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6)
!!!!! test failed
error: assert (randp (1e9, 1, 6),[1000006208, 1000012224, 999981120, 999963520, 
999963072,
999981440],1e-6) expected
   1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
but got
   1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
maximum absolute error 27 exceeds tolerance 1e-06
shared variables {
  __random_statistical_tests__ = 0
}
*************
2
*************
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\src\ov-fcn-handle.cc  PASS    2/3
   FAIL 1
  ***** test
 a = 2;
 f = @(x) a + x;
 g = @(x) 2 * x;
 h = @log2;
 f2 = f;
 g2 = g;
 h2 = h;
 nm = tmpnam();
 unwind_protect
   save ("-text", nm, "f2", "g2", "h2");
   clear f2 g2 h2
   load (nm);
   assert (f(2),f2(2));
   assert (g(2),g2(2));
   assert (g(3),g2(3));
   unlink (nm);
   save ("-text", nm, "f2", "g2", "h2");
 unwind_protect_cleanup
   unlink (nm);
 end_unwind_protect
!!!!! test failed
error: function handle points to non-existent function

**************
3
**************
  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\scripts/strings\mat2str.m  PASS
 2/3    FAIL 1
  ***** assert (mat2str ([-1/3 +i/7; 1/3 -i/7], [4 2]), 
"[-0.3333+0i,0+0.14i;0.3333+0i,-0-0.14i]")
!!!!! test failed
error: assert (mat2str ([-1 / 3, +i / 7; 1 / 3, -i / 7], [4,
2]),"[-0.3333+0i,0+0.14i;0.3333+0i,-0-0.14i]") expected
[-0.3333+0i,0+0.14i;0.3333+0i,-0-0.14i]
but got
[-0.3333+0i,0+0.14i;0.3333+0i,0-0.14i]
>>>>> processing 
>>>>> c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\scripts/strings\strcat.m
  ***** xtest
 assert(all (strcmp (strcat ("a", {"bc", "de"}, "f"), {"abcf", "adef"})))
!!!!! known failure
error: strcat: concatenating cell arrays of strings not implemented
*************
4
*************
 charset = setstr (0:127);
 
 result = zeros (1, 128);
 
 result (33:127) = 1;
 if (ispc () && ! isunix ())
   result(10) = 1;
 endif
 
 assert(all (isprint (charset) == result));
!!!!! test failed
error: assert (all (isprint (charset) == result)) failed
***************
skipped test
***************
>>>>> processing test_system
  ***** testif HAVE_GETPWUID
 x = getpwuid (getuid ());
 assert((strcmp (x.dir, tilde_expand ("~"))
 && strcmp (x.dir, tilde_expand (sprintf ("~%s", x.name)))
 && strcmp ("foobar", tilde_expand ("foobar"))));
----- skipped test
  ***** testif HAVE_GETPGRP
 assert(getpgrp () > 0);
----- skipped test
  ***** testif HAVE_GETPPID
 assert(getppid () > 0);
----- skipped test
  ***** testif HAVE_GETPWENT
 s = getpwent ();
 endpwent (); 
 assert((isstruct (s)
 && struct_contains (s, "name")
 && struct_contains (s, "passwd")
 && struct_contains (s, "uid")
 && struct_contains (s, "gid")
 && struct_contains (s, "gecos")
 && struct_contains (s, "dir")
 && struct_contains (s, "shell")));
----- skipped test
  ***** testif HAVE_GETPWUID
 x = getpwent ();
 y = getpwuid (x.uid);
 endpwent (); 
 assert(strcmp (x.name, y.name) && x.uid == y.uid && x.gid == y.gid);
----- skipped test
  ***** testif HAVE_GETPWNAM
 x = getpwent ();
 y = getpwnam (x.name);
 endpwent (); 
 assert(strcmp (x.name, y.name) && x.uid == y.uid && x.gid == y.gid);
----- skipped test
  ***** testif HAVE_SETPWENT
 x = getpwent ();
 setpwent ();
 y = getpwent ();
 endpwent (); 
 assert(strcmp (x.name, y.name) && x.uid == y.uid && x.gid == y.gid);
----- skipped test
  ***** testif HAVE_GETGRENT
 x = getgrent ();
 endgrent ();
 assert((isstruct (x)
 && struct_contains (x, "name")
 && struct_contains (x, "passwd")
 && struct_contains (x, "gid")
 && struct_contains (x, "mem")));
----- skipped test
  ***** testif HAVE_GETGRGID
 x = getgrent ();
 y = getgrgid (x.gid);
 endgrent ();
 assert(strcmp (x.name, y.name) && x.gid == y.gid);
----- skipped test
  ***** testif HAVE_GETGRNAM
 x = getgrent ();
 y = getgrnam (x.name);
 endgrent ();
 assert(strcmp (x.name, y.name) && x.gid == y.gid);
----- skipped test
  ***** testif HAVE_SETGRENT
 x = getgrent ();
 setgrent ();
 y = getgrent ();
 endgrent ();
 assert(strcmp (x.name, y.name) && x.gid == y.gid);
----- skipped test
>>>>> processing test_transpose
>>>>> processing test_try
>>>>> processing test_unwind
>>>>> processing test_while

Files with no tests:

The have sent 


Please see first
http://www.nabble.com/make-check-reults-for-octave-3.0.2-for-mingw-to19128571.html#a19128571



For No.1  the previous patch was not correct, please apply
--- a/src/DLD-FUNCTIONS/rand.cc Mon Aug 04 22:32:47 2008 -0400 
+++ b/src/DLD-FUNCTIONS/rand.cc Fri Aug 08 16:11:07 2008 +0900 
@@ -950,7 +950,7 @@ 
 %!test 
 %! % Test fixed state 
 %! randp("seed",1); 
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6) 
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e+2) 
 %!test 
 %! if (__random_statistical_tests__) 
 %!   % statistical tests may fail occasionally.

For No.4, please apply

--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400 
+++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900 
@@ -1,3 +1,7 @@ 
+2008-08-22  Tatsuro MATSUOKA  <address@hidden> 
+ 
+       test/octave.test/string/isprint-1.m in test_string.m for fixed. 
+ 
 2008-08-19  Jaroslav Hajek <address@hidden> 
  
        Version 3.0.2 released. 
diff -r 4908e39553b0 test/test_string.m 
--- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400 
+++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900 
@@ -532,7 +532,7 @@ 
 %! result = zeros (1, 128); 
 %! 
 %! result (33:127) = 1; 
-%! if (ispc () && ! isunix ()) 
+%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2)) 
 %!   result(10) = 1; 
 %! endif 




--------------------------------------
Enjoy MLB with MAJOR.JP! Ichiro, Matsuzaka, Matsui, and more!
http://pr.mail.yahoo.co.jp/mlb/