[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix null assignment: the (hopefully) final answer
From: |
Jaroslav Hajek |
Subject: |
Re: fix null assignment: the (hopefully) final answer |
Date: |
Sat, 27 Sep 2008 11:22:50 +0200 |
On Fri, Sep 26, 2008 at 11:39 PM, John W. Eaton <address@hidden> wrote:
> On 26-Sep-2008, Jaroslav Hajek wrote:
>
> | I'll transplant this into 3.0.3 rc2, as it probably fixes the problem
> | reported by Michael:
> | http://www.nabble.com/forum/Permalink.jtp?root=19645333&post=19675573&page=y
>
> Does the addition of new virtual functions in the octave_value class
> hierarchy cause any trouble for API stability?
>
As most C++ compilers use VMT pointers + static offsets, I'm afraid it
does. Maybe it wouldn't if the new method were the last one specified,
but I think we can't safely bet on that.
Thanks for the alert; I was not aware of this. Hmmm. In that case I'll
just transplant the bit of the patch that ignores null assignments
with empty indices (I think this was somehow handled in the assign
functions before).
> | Meanwhile, can you please apply the attached additional checks for
> | null assignment behaviour?
>
> Done.
>
> Thanks,
>
> jwe
>
--
RNDr. Jaroslav Hajek
computing expert
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz