Re: 3.0.3 release candidate 2

[Tatsuro MATSUOKA]

Hello

The patches
http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2008-September/008646.html

--- a/src/DLD-FUNCTIONS/rand.cc Mon Aug 04 22:32:47 2008 -0400 
+++ b/src/DLD-FUNCTIONS/rand.cc Fri Aug 08 16:11:07 2008 +0900 
@@ -950,7 +950,7 @@ 
 %!test 
 %! % Test fixed state 
 %! randp("seed",1); 
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6) 
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e+2) 
 %!test 
 %! if (__random_statistical_tests__) 
 %!   % statistical tests may fail occasionally.

*************
--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400 
+++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900 
@@ -1,3 +1,7 @@ 
+2008-08-22  Tatsuro MATSUOKA  <tmacchant at ...> 
+ 
+       test/octave.test/string/isprint-1.m in test_string.m for fixed. 
+ 
 2008-08-19  Jaroslav Hajek <highegg at ...> 
  
        Version 3.0.2 released. 
diff -r 4908e39553b0 test/test_string.m 
--- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400 
+++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900 
@@ -532,7 +532,7 @@ 
 %! result = zeros (1, 128); 
 %! 
 %! result (33:127) = 1; 
-%! if (ispc () && ! isunix ()) 
+%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2)) 
 %!   result(10) = 1; 
 %! endif 
 %!

************

were not applied.

However, this time I have built octave with gcc-4.3.2-tdm.
The second patch is not needed.

The first patch should be wrtten
--- a/src/DLD-FUNCTIONS/rand.cc Mon Aug 04 22:32:47 2008 -0400 
+++ b/src/DLD-FUNCTIONS/rand.cc Fri Aug 08 16:11:07 2008 +0900 
@@ -950,7 +950,7 @@ 
 %!test 
 %! % Test fixed state 
 %! randp("seed",1); 
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6) 
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],-1e-6) 
 %!test 
 %! if (__random_statistical_tests__) 
 %!   % statistical tests may fail occasionally.

because
octave.exe:7> randp("seed",1);
octave.exe:8> assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 
999963072
999981440],1e-6)
error: assert (randp (1e9, 1, 6),[1000006208, 1000012224, 999981120, 999963520,
999963072, 999981440],1e-6) expected
   1000006208   1000012224    999981120    999963520    999963072    999981440
but got
   1000006225   1000012251    999981100    999963538    999963053    999981432
maximum absolute error 27 exceeds tolerance 1e-006
error: called from `assert' in file
`c:\usr\Tatsu\mingwhome\octaves\octave-3.0.3\scripts\testfun\assert.m'

octave.exe:5> randp("seed",1);
octave.exe:6> assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 
999963072
999981440],-1e-6)

'-' is required to be relative tolerance as David suggested.

http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2008-September/008649.html


Anyway there are no intrinsic change has not been found for candidate 2.
I think it is OK you to go forward in terms of mingw building.

Regards

Tatsuro

--- Jaroslav Hajek <address@hidden> wrote:

> hello,
> 
> the 3.0.3 RC2 is up for testing. Some last-minute fixes were added.
> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
> 
> regards
> 
> -- 
> RNDr. Jaroslav Hajek
> computing expert
> Aeronautical Research and Test Institute (VZLU)
> Prague, Czech Republic
> url: www.highegg.matfyz.cz
> 


--------------------------------------
Enjoy MLB with MAJOR.JP! Ichiro, Matsuzaka, Matsui, and more!
http://pr.mail.yahoo.co.jp/mlb/