Re: Should the attached be applied?

[Jaroslav Hajek]

On Thu, Nov 13, 2008 at 11:09 PM, David Bateman <address@hidden> wrote:
> I think we need the patch
>
> diff --git a/liboctave/Array2.h b/liboctave/Array2.h
> --- a/liboctave/Array2.h
> +++ b/liboctave/Array2.h
> @@ -117,14 +117,14 @@
>    }
>
>  Array2<T> index (idx_vector& i, int resize_ok = 0,
> -           const T& rfv = resize_fill_value (T ())) const
> +           const T& rfv = Array<T>::resize_fill_value ()) const
>    {
>      Array<T> tmp = Array<T>::index (i, resize_ok, rfv);
>      return Array2<T> (tmp, tmp.rows (), tmp.columns ());
>    }
>
>  Array2<T> index (idx_vector& i, idx_vector& j, int resize_ok = 0,
> -           const T& rfv = resize_fill_value (T ())) const
> +           const T& rfv = Array<T>::resize_fill_value ()) const
>    {
>      Array<T> tmp = Array<T>::index (i, j, resize_ok, rfv);
>      return Array2<T> (tmp, tmp.rows (), tmp.columns ());
>
> But perhaps Jaroslav should comment as this touches on his recent indexing
> changes..
>

Yes. I'm a little surprised that this went unnoticed - apparently that
method is not instantiated anywhere in Octave.


> D.
>
> --
> David Bateman                                address@hidden
> 35 rue Gambetta                              +33 1 46 04 02 18 (Home)
> 92100 Boulogne-Billancourt FRANCE            +33 6 72 01 06 33 (Mob)
>
>



-- 
RNDr. Jaroslav Hajek
computing expert
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz