octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [changeset] clean up __xzip__, gzip and bzip2, fix broken documentat


From: Thorsten Meyer
Subject: Re: [changeset] clean up __xzip__, gzip and bzip2, fix broken documentation
Date: Sat, 29 Nov 2008 23:42:41 +0100
User-agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018)

address@hidden wrote:
> On Sat, Nov 29, 2008 at 11:06:12PM +0100, Thorsten Meyer wrote:
>> Thorsten Meyer wrote:
>>> attached you will find a changeset that cleans up the functions __xzip__, 
>>> gzip and
>>> bzip2. In particular, it removes the @seealso references to __xzip__ which 
>>> led to
>>> a build failure of the documentation.
>>>
>> oops, there was a little bug in the bzip2 test. Here a corrected version of 
>> the changeset:
> 
> As far as I can see this patch removes an if/endif block as "files" is 
> always a cell array of strings, and the rest is just the changes 
> mentioned above that are relatively minor or whitespace changes.. The 
> whitespace changes as a rare large amount of this patch, so can you 
> confirm that the code in the deleted if/endif block just underwent 
> whitespace changes..
> 
> D.
> 
Almost: the check for the type of the FILES argument is not gone. I just moved 
it upwards  where it
seemed more natural to me.

Thorsten



reply via email to

[Prev in Thread] Current Thread [Next in Thread]