octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with test_perfer.m


From: Ben Abbott
Subject: Re: Problem with test_perfer.m
Date: Fri, 23 Jan 2009 12:35:35 -0500

On Friday, January 23, 2009, at 12:18PM, "Soren Hauberg" <address@hidden> wrote:
>fre, 23 01 2009 kl. 14:07 +0100, skrev Soren Hauberg:
>> fre, 23 01 2009 kl. 07:32 -0500, skrev Ben Abbott:
>> > Does this test pass for you?
>> 
>> No it does not -- this is a bug. I'll send a changeset once I've made a
>> build of latest upstream sources.
>
>Okay, attached is a changeset that fixes the problem. The change is
>fairly large, but it mostly consist of moving the content of the
>'do_type' function into the body of the 'type' function. This was needed
>for 'evalin ("caller", ...)' to work.
>
>However, the test still fails. The problem is that the old
>implementation of 'type' behaved IMHO a bit weird when you asked for an
>output argument. If you did
>
>  text = type ('fun1', 'fun2');
>
>you would get the code of both functions in one string. To me it makes
>more sense to put the code of these two functions in a cell array, which
>is what the current code does.

fwiw, I prefer what the current code does.

Ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]