Re: 3.0.4 RC3 (mingw 3.4.5)-2

[Tatsuro MATSUOKA]

Hello Jaroslav Hajek

Thank you for your efforts.

I have tested 3.0.4 RC3 using mingw-3.4.5.

Integrated test scripts:

  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\src\ov-fcn-handle.cc  PASS    
2/3    FAIL 1
  
d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\scripts/miscellaneous\fileparts.m
  PASS    6/9   
FAIL 3
  test_string.m .......................................... PASS  130/131  FAIL 1

  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\src\ov-fcn-handle.cc  PASS    
2/3    FAIL 1
This is perhaps not problem for Benjamin's build. (Hi Benjamin, am I right?)

  
d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\scripts/miscellaneous\fileparts.m
  PASS    6/9   
FAIL 3
>>>>> processing 
>>>>> d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\scripts/miscellaneous\fileparts.m
  ***** test
 [d, n, e] = fileparts (["d1" filesep "d2" filesep "file.ext"]);
 assert (strcmp (d, "d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "d1/d2") && strcmp (n, "file") && strcmp (e, ".ext")) 
failed
  ***** test
 [d, n, e] = fileparts ([filesep "d1" filesep "d2" filesep "file.ext"]);
 assert (strcmp (d, "/d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "/d1/d2") && strcmp (n, "file") && strcmp (e, 
".ext")) failed
  ***** test
 [d, n, e] = fileparts ([filesep ".ext"]);
 assert (strcmp (d, "/") && strcmp (n, char (zeros (1, 0))) && strcmp (e, 
".ext"));
!!!!! test failed
error: assert (strcmp (d, "/") && strcmp (n, char (zeros (1, 0))) && strcmp (e, 
".ext")) failed


Sorry my patch seemed to be partly wrong.

Sorry I could not to use Mercurial correctly so I offer diff -u -r.
(Perhaps this style is similar to hg changeset)

The below patch corrects the errors like
  
d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC3\scripts/miscellaneous\fileparts.m
  PASS    9/9

Anyway no fatal errors exist now!!!!

Regards

Tatsuro


$ diff -u -r ./a/scripts/miscellaneous/fileparts.m 
./b/scripts/miscellaneous/fileparts.m
--- ./a/scripts/miscellaneous/fileparts.m       Thu Jan 29 17:40:42 2009
+++ ./b/scripts/miscellaneous/fileparts.m       Fri Jan 30 16:54:26 2009
@@ -82,15 +82,15 @@

 %!test
 %! [d, n, e] = fileparts (["d1" filesep "d2" filesep "file.ext"]);
-%! assert (strcmp (d, "d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
+%! assert (strcmp (d, ["d1" filesep "d2"]) && strcmp (n, "file") && strcmp (e, 
".ext"));

 %!test
 %! [d, n, e] = fileparts ([filesep "d1" filesep "d2" filesep "file.ext"]);
-%! assert (strcmp (d, "/d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
+%! assert (strcmp (d, [filesep "d1" filesep "d2"]) && strcmp (n, "file") && 
strcmp (e, ".ext"));

 %!test
 %! [d, n, e] = fileparts ([filesep ".ext"]);
-%! assert (strcmp (d, "/") && strcmp (n, char (zeros (1, 0))) && strcmp (e, 
".ext"));
+%! assert (strcmp (d, filesep) && strcmp (n, char (zeros (1, 0))) && strcmp 
(e, ".ext"));

 %!test
 %! [d, n, e] = fileparts (".ext");





 



--- Jaroslav Hajek wrote:

> hello,
> 
> the octave 3.0.4 rc3 tarballs are available from the usual location:
> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
> 
> sorry for the longer delays. I've only recently discovered a day is
> limited to 24 hours.
> 
> cheers
> 
> -- 
> RNDr. Jaroslav Hajek
> computing expert
> Aeronautical Research and Test Institute (VZLU)
> Prague, Czech Republic
> url: www.highegg.matfyz.cz
> 

Sorru

--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/