octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[changeset] Missing ScreenSize & ScreenPixelsPerInch properties


From: John W. Eaton
Subject: [changeset] Missing ScreenSize & ScreenPixelsPerInch properties
Date: Tue, 17 Feb 2009 00:45:15 -0500

On  5-Feb-2009, Thomas Treichl wrote:

| Thomas Treichl schrieb:
| >> | > | (b) Turn off empty output of configuration summary if Carbon is 
| >> used, eg.
| >> | > | | > |    X11 include flags:
| >> | > |    X11 libraries:
| >> | > | | > | and turn on output about Carbon framework instead, eg.
| >> | > | | > |    Carbon libraries: -Wl,-framework -Wl,Carbon
| >> | > | > I don't think this part is really necessary, so I'd say omit it.
| >> | | Yes ok.
| >>
| >> I meant the part about removing the empty X11 include and library
| >> flags.  It would be OK to put the Carbon libraries in the summary if
| >> they are stored in a separate variable.  But I see that you are
| >> currently adding them to LIBS, so in that case I don't think a
| >> separate line is needed.
| > 
| > I may come back to this idea somewhen the next days, is $(CARBON_LIBS) 
| > okay?
| 
| I attached a changeset that uses $(CARBON_LIBS) instead of just $(LIBS). 
Should 
| this also find its place in mkoctfile.in and octave-config.in? I was looking 
for 
| $(X11_LIBS) in these files but couldn't find any, my implementation leans on 
X11 
| ie. I can more easily find out where it should be added. I'll also send a 
| changeset for the documentation when I've finished the framework OpenGL test, 
too.

I applied this changeset, and also added CARBON_LIBS, X11_INCFLAGS,
and X11_LIBS to the octave_config_info struct.  Changeet here:

  http://hg.savannah.gnu.org/hgweb/octave/rev/d3382daaf4d2

Thanks,

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]