[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
summary mangling with pushed patches
From: |
Thomas Weber |
Subject: |
summary mangling with pushed patches |
Date: |
Mon, 23 Feb 2009 19:56:21 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
I just had a look at patch 93cf10950334, which has the following summary
line:
summary: tmpdir=tmpnam;
This looks odd and indeed:
hg log -v -r 93cf10950334
========================================================================
description:
tmpdir=tmpnam;
tmpfile=tmpnam;
dummy=1;
save(tmpfile, "dummy")
mkdir(tmpdir)
gzfile=gzip(tmpfile, tmpdir)
gunzip(gzfile)
Include cstdio header.
Without this header inclusion, compilation of oct-md5.cc and gethelp.cc
with g++ 4.4 fails because symbols like sprintf, fopen, fread, fclose,
and
EOF are not found.
========================================================================
I don't know if that's a one time glitch, but in case the pushing
happens via a script, that script has bug :)
Thomas
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- summary mangling with pushed patches,
Thomas Weber <=