Re: [PATCH 4 of 4] Implement diag + sparse, diag - sparse, sparse + diag, sparse - diag

[John W. Eaton]

On 10-Mar-2009, Jason Riedy wrote:

| And John W. Eaton writes:
| > Will you please send changesets as attachments so that mailers won't
| > mangle them?
| 
| Will do.  Annoyingly enough, only Mercurial's own hg email seems to
| mangle them.

Changing "From " at the beginning of a line to ">From " is necessary
to avoid confusing tools that work with the Unix mbox mail file
format.  That's the only thing I've noticed so far with your patches,
but if you send patch in the message body, there is some chance that
some mailer along the way will screw it up in other ways.  So it is
just better to use an attachment.

| BTW, how are you applying patches?  They seem to lose the commit
| messages.  I thought hg import would do the right thing, but I'm not too
| familiar with Mercurial.

I extract it directly from an Emacs VM mail buffer and send it through
"hg qimport" to put the patch in a local patch queue, then I modify as
needed before doing "hg qrefresh -D" and "hg qfinish -a", then I push
the change to savannah.  I don't strip out the commit message, and it
seems to be intact in the latest change I imported.

In any case, I think detailed information about why a change is needed
belongs in a comment in the sources, not in a commit message or
ChangeLog entry.

Also, I don't understand the purpose of the

  From 76c98628f1943d583d5813321ec0a3c684d7ac84 Mon Sep 17 00:00:00 2001

and

  Signed-off-by: Jason Riedy <address@hidden>

lines in your commit messages.

jwe