[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: units conversion (was: about contibuting to octave)
From: |
Michael Goffioul |
Subject: |
Re: units conversion (was: about contibuting to octave) |
Date: |
Mon, 20 Apr 2009 12:14:29 +0100 |
On Mon, Apr 20, 2009 at 11:27 AM, Shai Ayal <address@hidden> wrote:
> On Mon, Apr 20, 2009 at 12:17 PM, xianghang liu <address@hidden> wrote:
>> I tried again and found fltk_backend.oct could be built successfully with a
>> few modifications of fltk_backend.cc. The modification I made was moving
>> "#ifdef min ... #endif" which is originally in the middle of "#include ..."
>> instructions to the end them. Now it compiles fine and works well.
>
> I see this change was introduced by Michael in changeset 7965:
> http://hg.savannah.gnu.org/hgweb/octave/rev/6a6a030a3517
> with the comment "Fix compilation under MSVC".
> Will moving the #ifdef block below all includes break MSVC?
> If not then I say move it.
This might break compilation on MSVC. Could you track down
why you need to keep min and max #define'd?
Michael.